Maintaining your own branch of Drupal core

[object Object],[object Object],[object Object],[object Object]

[object Object],[object Object],[object Object]

Patch reviews Collected 16/Sep/2007

Top reviewers 318 total Collected 16/Sep/2007 Number of issues changed from needs review or ready to commit

Top patch writers 830 total Collected 16/Sep/2007 Number of issues posting an attachment follow up

Code style if (arg(0) == 'node' && arg(1) == 'add' && $type = arg(2)) { $type = node_get_types('type', str_replace('-', '_', arg(2))); - return '<p>'. filter_xss_admin($type->help) .'</p>'; + + if ( $help = filter_xss_admin($type->help) ) { + return '<p>'. $help .'</p>'; + } } } http://drupal.org/node/112140

Functionality ,[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]

Usability ,[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]

Scalability $sql = 'SELECT DISTINCT u.uid, u.name, u.status, u.created, u.access FROM {users} u LEFT JOIN {users_roles} ur ON u.uid = ur.uid '. $filter['join'] .' WHERE u.uid != 0 '. $filter['where']; $sql .= tablesort_sql($header); - $result = pager_query($sql, 50, 0, NULL, $filter['args']); + $count_sql = 'SELECT COUNT(DISTINCT(u.uid)) FROM {users} u LEFT JOIN {users_roles} ur ON u.uid = ur.uid '. $filter['join'] .' WHERE u.uid != 0 '. $filter['where'] ; + $count_sql .= tablesort_sql($header); + + $result = pager_query($sql, 50, 0, $count_sql, $filter['args']); $form['options'] = array( '#type' => 'fieldset', ,[object Object]

Security $session_name = $cookie_domain; } else { + // If the site is using session.cookie_secure, use $base_url as + // session name. + if (ini_get('session.cookie_secure')) { + $session_name = $base_url; + } // Otherwise use $base_url as session name, without the protocol // to use the same session identifiers across http and https. - list( , $session_name) = explode('://', $base_url, 2); + else { + list( , $session_name) = explode('://', $base_url, 2); + } // We try to set the cookie domain to the hostname. // We escape the hostname because it can be modified by a visitor. if (!empty($_SERVER['HTTP_HOST'])) { ,[object Object]

How to review a patch ,[object Object],[object Object],[object Object],[object Object],[object Object],More at http://drupal.org/patch/review

Maintaining your own branch of Drupal core

Recomendados

Recomendados

Más contenido relacionado

La actualidad más candente

La actualidad más candente (20)

Similar a Maintaining your own branch of Drupal core

Similar a Maintaining your own branch of Drupal core (20)

Último

Último (20)

Maintaining your own branch of Drupal core