Slides de la charla "Refactorización de aplicaciones PHP/Symfony2" en deSymfony

3. Raúl Fraile
• Software developer en
• PHP 5.3 Zend Certified Engineer
• Symfony Certified Developer
• LadybugPHP
raulfraile

4. 1. Refactoring 101
2. Coding Standard
3. IDE
4. Separación código/datos
5. Acoplamiento al entorno
6. Don’t Repeat Yourself
7. Fat controllers
Agenda

5. Proyecto de prueba

6. APIJokes (I)
GET /api/list
Obtiene la lista de chistes en JSON
POST /api/add
Añade un nuevo chiste
POST /api/edit
Edita un chiste
GET /
Web con la lista de chistes en HTML

7. APIJokes (II)
Casos especiales
Se envía un email al administrador
cada vez que se añade o edita un
chiste.
No se permiten chistes sobre Java.

8. raulfraile/apijokes

9. Refactoring 101

10. Reescribir VS Refactorizar

11. Reescribir
http://www.flickr.com/photos/meliah/2601885140/

12. http://www.flickr.com/photos/90692443@N05/8239219385/
Refactorizar

13. Refactorizar debe ser un
proceso contínuo

15. Siempre partiendo de un
software que funciona...

16. ...y con tests

17. Coding Standard

18. http://www.flickr.com/photos/zpeckler/2835570492/
¿Cambiar de CS?

19. Importante: Elegir un CS
y ser consistente

20. Proyectos open source:
compartir mismo CS

21. PSR-1/2

23. http://cs.sensiolabs.org

24. php-cs-fixer fix ApiJokesBundle/ --level=all --dry-run --diff -v
1) Controller/WebsiteController.php (braces, return)
---------- begin diff ----------
--- Original
+++ New
@@ @@
-class WebsiteController extends Controller {
- public function indexAction() {
+class WebsiteController extends Controller
+{
+ public function indexAction()
+ {
$em = $this->getDoctrine()->getManager();
$jokes = $em->getRepository('...')->findAll();
+
return $this->render('...', array(
'jokes' => $jokes
));
}
}
---------- end diff ----------

25. IDE

26. Problemas: DIC, foreach,
repositorios...

27. <?php
$mailer = $this->get('mailer');
$mailer->send($message);

28. <?php
/** @var $mailer Swift_Mailer */
$mailer = $this->get('mailer');
$mailer->send($message);

29. Type hints, aunque no
solo por el IDE

30. <?php
$data = array_map(function ($item) {
return array(
'id' => $item->getId(),
'content' => $item->getContent()
);
}, $jokes);

31. <?php
$data = array_map(function (Joke $item)
{
return array(
'id' => $item->getId(),
'content' => $item->getContent()
);
}, $jokes);

32. Separación
código/datos

33. Son distintos
http://www.flickr.com/photos/yukariryu/121153772/

34. Un cambio en datos o
configuración no debe
requerir cambiar código

35. public function load(ObjectManager $manager)
{
$jokes = array(
'There’s no place like 127.0.0.1',
'If at first you don’t succeed; call it version 1.0',
'Beware of programmers that carry screwdrivers',
'What color do you want that database?'
);
foreach ($jokes as $item) {
$joke = new Joke();
$joke->setContent($item);
$manager->persist($joke);
}
$manager->flush();
}

36. # fixtures/joke.yml
jokes:
- 'I would love to change the world, but they won’t...'
- 'There’s no place like 127.0.0.1'
- 'If at first you don’t succeed; call it version 1.0'
- 'You know it’s love when you memorize her IP...'
- 'Beware of programmers that carry screwdrivers'
- 'Best file compression around: “rm *.*” = 100...'
- 'The truth is out there…anybody got the URL?'
- 'What color do you want that database?'

37. public function load(ObjectManager $manager)
{
$jokes = Yaml::parse(__DIR__ . '/fixtures/joke.yml');
foreach ($jokes['jokes'] as $item) {
$joke = new Joke();
$joke->setContent($item);
$manager->persist($joke);
}
$manager->flush();
}

38. Acoplamiento al
entorno

39. http://www.flickr.com/photos/darkhornet/4945282009/
FAIL

40. {% if app.environment == 'prod' %}
<script type="text/javascript">
// Google Analytics code
</script>
{% endif %}

41. La aplicación no debe
tomar decisiones
dependiendo del entorno

42. Mejor: configuraciones
distintas por entorno

43. {% if enable_analytics %}
<script type="text/javascript">
// Google Analytics code
</script>
{% endif %}

44. Don’t Repeat
Yourself

45. // do not allow jokes about java)
if (stripos($content, 'java') !== false) {
throw new BadRequestHttpException(
'Java jokes are not allowed'
);
}

46. use SymfonyComponentValidatorConstraint;
/**
* @Annotation
*/
class ContainsJava extends Constraint
{
public $message = 'Java jokes are not allowed';
}

47.
use SymfonyComponentValidatorConstraint;
use SymfonyComponentValidatorConstraintValidator;
class ContainsJavaValidator extends ConstraintValidator
{
public function validate($value, Constraint $constraint)
{
if (stripos($value, 'java') !== false) {
$this->context->addViolation($constraint->message);
}
}
}

48. Fat controllers

49. ¡A dieta!
http://www.flickr.com/photos/golf_pictures/3017331832/

50. Configuración, eventos,
anotaciones, servicios, métodos
más simples, herencia, param
converters...

51. https://joind.in/8835
¿Preguntas?