Recommended
More Related Content
What's hot
What's hot (19)
Viewers also liked
Viewers also liked (20)
Similar to How Google Said - Ninja Code Review With Gerrit
Similar to How Google Said - Ninja Code Review With Gerrit (20)
Recently uploaded
Recently uploaded (20)
How Google Said - Ninja Code Review With Gerrit
- 1. How Google Said Ninja Code Review created by Anuar Nurmakanov 1
- 2. -35 ? Welcome to Java User Group!!! 2
- 3. About me Kazakhstan, Karaganda Lead Software Engineer XP/EngX Practices fan Agile Believer And I love Java! 3
- 4. What does it mean to be brave developer? 4
- 5. Intro The world without you... 5
- 6. When you start new project It's new opportunity. You feel like a hero! It's gonna be the best project!! 6
- 7. Sometimes our projects become 7
- 9. And it is tough to make it better 9
- 10. And only one thing you wanna do Run away!!!!!! 10
- 11. Why? 11
- 13. Lack of Code Review Lack of TDD Lack of Testing Pyramid Lack of CI/CD/CD Lack of Release Strategy and other engineering and agile practices 13
- 14. A few words about Code Review 14
- 15. How much does it cost? 15
- 16. When you fix it too late... 16
- 17. Code Review Goals Definition of Done Collective Code Ownership Code Quality Knowledge Sharing Find compromise Education 17
- 19. Code Review Is so huuuuuge topic Why and when Benefits Goals Approaches Roles Strategies Tools Best practices etc 19
- 20. Your code is not your wife! You can share it! First rule of Code Review 20
- 22. Before or After Changes aren't in a branch. Changes are in in a branch. 22
- 23. Make the right decision To prevent anything like this 23
- 25. No one can make pushes Jenkins is red We cannot prepare build Fix might break one of the test environments It might take lots of time 25
- 26. Who broke the build? 26
- 27. Stable build 27
- 28. What is Stable build? Changes do not have any bugs They do not fail existing tests They have good test coverage CI jobs are green Unit/Integration/System/End- To-End tests passed Existing functionality works 28
- 29. I wanna see everything in one place Feedback from teammates Feedback from Team Lead Feedback from Architect Check that build is not broken Check any type of tests Feedback from Architect New violations and errors Any blocker issues Any static analyse 29
- 31. Branching Strategies Feature Branch Development Git Flow Mainline Trunk Based Development 31
- 32. 32
- 33. 33
- 34. 34
- 35. 35
- 36. Trunk Based Development Everyone Develops in the trunk Bug fixes too No Code Freeze No Merge Hell Build never broken. It's always ready to be released 36
- 37. Don't mix them up 37
- 39. 39
- 40. Only with patches Forget about CI integration Forget about Static Analyse Integration 40
- 42. Pull requests are not pure pre-commit review You can integrate it with CI. Some have CI out of the box Pull requests do not show Static Code Analyse comments Pull/Merge Requests 42
- 43. Gerrit Ninja 43
- 44. Who is Ninja? Always ready to hear feedback from others and make changes Fixes build before it breaks main branches builds Removes all SonarQube violations Knows how GIT works Ready to share knowledge and help Checks Unit/Integration/System/End- To-End/UI tests 44
- 45. What is Gerrit? Created for Android Development and now it's in Google And lots of other companies 45
- 47. Gerrit Review 47
- 49. Access Control A developer can say that it's good Architects and Leads can approve merge 49
- 50. Gerrit Roles Model Group Label Range Registered Users Code-Review -1..+1 Team Leads Code-Review -2..+1 Architects Code-Review -2..+2 Non-interactive users Code-Review -1..+1 “ For example, only Architects can allow to make a merge 50
- 51. Patch Set One code change, (be it a feature or a bugfix, ) is one commit. Use Ammend to update it. git push gerrit HEAD:refs/for/master When it's ready for review 51
- 52. Live Demo Let's check it out. 52
- 53. If you have a chance to try it Do it! 53
- 54. Gerrit Users Android – LibreOffice – Wikimedia – Golang – Tuleap – Star Wars Galaxies Emulator – https://android-review.googlesource.com/ https://gerrit.libreoffice.org/ https://gerrit.wikimedia.org/ https://go-review.googlesource.com/ https://gerrit.tuleap.net/ http://review.swgemu.com/ 54
- 55. Thanks Feel free to ask any questions. =) 55