Presented at Multi-Mania in Kortrijk, Belgium on May 24, 2011.

1. Code Review:
An Apple A Day

2. About me

3. About me
Kathryn Rotondo

4. About me
Kathryn Rotondo
flashionista.org

5. About me
Kathryn Rotondo
flashionista.org
@krotondo

6. About me
Kathryn Rotondo
flashionista.org
@krotondo
Adobe Community
Champion (ACC)

7. About me
Kathryn Rotondo
flashionista.org
@krotondo
Adobe Community
Champion (ACC)
Soft wareent wicklerin

8. What is Code
Review?

9. Historically

10. Recently

11. Now

12. How often?

13. Every Commit!

14. Benefits

15. “As I've learned over the last
t wo years at Google, proper
code review habits can
really improve the quality
of a code base, and good
tools for code review will
improve developers' life.”

16. Benefits

17. Benefits
Distributes project knowledge

18. Benefits
Distributes project knowledge
Provides learning opportunities

19. Benefits
Distributes project knowledge
Provides learning opportunities
Catches Bugs

20. Benefits
Distributes project knowledge
Provides learning opportunities
Catches Bugs
Encourages Tidiness

21. Benefits
Distributes project knowledge
Provides learning opportunities
Catches Bugs
Encourages Tidiness
Saves Time

22. Distributes Project
Knowledge

23. Provides Learning
Opportunities

24. Catches Bugs

25. Encourages Tidiness

26. Saves Time

27. Tools

28. Flex Formatter

29. Flex Formatter
Available on
SourceForge

30. Flex Formatter
Available on
SourceForge
Grant Skinner calls it
an “Indispensable
Plugin for Flash
Builder”

31. Flex Formatter

32. Flex Formatter
Team agrees on a
style

33. Flex Formatter
Team agrees on a
style
Team members install
plugin & configure it
with team styleheet

34. Flex Formatter
Team agrees on a
style
Team members install
plugin & configure it
with team styleheet
Plugin auto-applies
style with every save

35. Flex Formatter
Team agrees on a
style
Team members install
plugin & configure it
with team styleheet
Plugin auto-applies
style with every save

36. Flex Formatter
Team agrees on a Effortless!
style
Team members install
plugin & configure it
with team styleheet
Plugin auto-applies
style with every save

37. Flex Formatter
Team agrees on a Effortless!
style
Removes style as
Team members install distraction during
plugin & configure it code review process
with team styleheet
Plugin auto-applies
style with every save

38. Flex Formatter
Team agrees on a Effortless!
style
Removes style as
Team members install distraction during
plugin & configure it code review process
with team styleheet
Ensures that diffs
Plugin auto-applies show only code
style with every save changes, not style
differences

39. Google Code Reviews

40. Google Code Reviews
Available on Google
Apps Marketplace

41. Google Code Reviews
Available on Google
Apps Marketplace
Free to individuals/
organizations with
Google Apps account

42. Google Code Reviews
Available on Google
Apps Marketplace
Free to individuals/
organizations with
Google Apps account
Every line of Google
source code is
reviewed this way

43. Google Code Reviews

44. Google Code Reviews
a website

45. Google Code Reviews
a website
developer puts patch
up for review, anyone
else on team can
review it

46. Google Code Reviews
a website
developer puts patch
up for review, anyone
else on team can
review it
easy to see what code
has changed: green
for added, red for
removed

47. Google Code Reviews
a website reviewer can double-
click on a line of code
developer puts patch to insert comments
up for review, anyone inline
else on team can
review it
easy to see what code
has changed: green
for added, red for
removed

48. Google Code Reviews
a website reviewer can double-
click on a line of code
developer puts patch to insert comments
up for review, anyone inline
else on team can
review it allows iteration, so
developer can update
easy to see what code patch based on
has changed: green comments
for added, red for
removed

49. Riet veld Upload Script

50. Riet veld Upload Script
Available at Riet veld
on Google App Engine

51. Riet veld Upload Script
Available at Riet veld
on Google App Engine
By Guido Van Rossum,
creator of Python

52. Riet veld Upload Script

53. Riet veld Upload Script
Developer runs the
script when they’re
ready to have code
reviewed.

54. Riet veld Upload Script
Developer runs the
script when they’re
ready to have code
reviewed.
It creates a “diff”
showing what has
changed, and uploads
it to Google Code
Reviews

55. Riet veld Upload Script
Developer runs the Can be customized to
script when they’re match your team’s
ready to have code needs
reviewed.
It creates a “diff”
showing what has
changed, and uploads
it to Google Code
Reviews

56. Process / Demo

57. Developer

58. Developer
Writes code

59. Developer
Writes code
Uploads patch

60. Developer
Writes code
Uploads patch
Auto-emails reviewers

61. Developer
Writes code
Uploads patch
Auto-emails reviewers

62. Developer Reviewer
Writes code
Uploads patch
Auto-emails reviewers

63. Developer Reviewer
Writes code Visits website
Uploads patch
Auto-emails reviewers

64. Developer Reviewer
Writes code Visits website
Uploads patch Browses side-by-side diffs
Auto-emails reviewers

65. Developer Reviewer
Writes code Visits website
Uploads patch Browses side-by-side diffs
Auto-emails reviewers Responds inline

66. Developer Reviewer
Writes code Visits website
Uploads patch Browses side-by-side diffs
Auto-emails reviewers Responds inline
Publishes comments

67. Developer Reviewer
Writes code Visits website
Uploads patch Browses side-by-side diffs
Auto-emails reviewers Responds inline
Publishes comments

68. Questions?

69. Customize Upload.py
Upload Server
Patch Subject

70. Upload Server (-s)
Lines 82-84:
# URL of the default review
server. As for AUTH_ACCOUNT_TYPE,
this line could be
# changed by the review server
(see handler for upload.py).
DEFAULT_REVIEW_SERVER =
"codereview.appspot.com"

71. Issue Subject (-m)
Lines 2116-2120:
if options.issue:
prompt = "Message describing this patch
set: "
else:
prompt = "New issue subject: "
message = options.message or
raw_input(prompt).strip()