The document discusses software development practices and conventions, specifically around code quality and organization. It touches on topics like code formatting, complexity, comments, naming, and identifying "broken windows" or weaknesses that could degrade code quality over time if not addressed. The author advocates continuously improving practices by discussing options and making incremental changes.

1. Pra começar...

2. 1969

3. 1969
Hmm...
I have this
idea

4. 1969
Hmm...
I have this
idea

7. 10 minutes

9. 1 week

10. wait!

11. what if...

12. what if...

13. Just like the Bronx!

15. No one cares

16. No one cares
Why should I?

17. Broken
windows de
práticas
Ceci Fernandes
@cecifernandes

18. Which practices?

19. Which practices?
Diz aí!

20. practices
process

21. pair programming

22. daily meeting

23. definition of done

24. continuous
delivery
or
continuous
deployment

25. practices
process
many other

26. practices
process
code

27. Code conventions make
you feel too conventional?

28. Code conventions make
you feel too conventional?
Let's
make it
better!

29. Much
better
now...

30. Not for
long.

31. Code conventions

32. public class Taxi {
public double cobra(double km, int minutos) {
if (horarioPadrao())
{
return precoBase(km, minutos);
} else
return precoBase(km, minutos) * extra;
}
}

33. public class Taxi {
public double cobra(double km, int minutos) {
if (horarioPadrao())
return precoBase(km, minutos);
else
return precoBase(km, minutos) * extra;
}
}

34. public class Taxi {
public double cobra(double Km, int minutos) {
if (horario_padrao())
return precoBase(Km, minutos);
else
return precoBase(Km, minutos) * EXTRA;
}
}

35. public class Taxi {
public double cobra(double km, int t) {
double valor = calcula(km, t);
if (maisCaro()) {
return valor * extra;
}
return valor;
}
}

36. public class Taxi {
public double cobra(double km,int minutos) {
if (horarioPadrao()) return precoBase(km,minutos);
else return precoBase(km,minutos)*extra;
}
}

38. ?

39. Your turn!
What can you do?

41. Não é pela
posição
das chaves

42. What
conventions
then?

43. public void atualiza(final List<Parcela> parcelasAAtualizar,
final Usuario usuario, List<Feriado> feriados) {
for (Parcela p : parcelasAAtualizar) {
if (old.isInicial() || auxiliar || financeiro) {
if (old.getConta() != null) {
//
}
if (p.getConta() != null) {
//
}
}
if (!old.isFinal()) {
if (auxiliar || financeiro) {
//
if(old.getPodeUsarNovosCamposDeImposto()) {
//
} else {
//
}
}
// goes on a long way...

44. public void atualiza(final List<Parcela> parcelasAAtualizar,
final Usuario usuario, List<Feriado> feriados) {
for (Parcela p : parcelasAAtualizar) {
if (old.isInicial() || auxiliar || financeiro) {
if (old.getConta() != null) {
//
}
if (p.getConta() != null) {
//
}
}
if (!old.isFinal()) {
if (auxiliar || financeiro) {
//
if(old.getPodeUsarNovosCamposDeImposto()) {
//
} else {
//
}
}
// goes on a long way...
Cyclomatic
complexity

45. public TurmaController(HorarioDao horarioDao,
TurmaDao turmaDao, SalaDao salaDao,
CursoDao cursoDao, Info info,
HttpServletResponse response, Result result,
EnhancedValidator enhancedValidator,
UsuarioDao usuarioDao,
InstrutorEmAulaDao instrutorEmAulaDao) {
this._________ = _________;
}

46. public TurmaController(HorarioDao horarioDao,
TurmaDao turmaDao, SalaDao salaDao,
CursoDao cursoDao, Info info,
HttpServletResponse response, Result result,
EnhancedValidator enhancedValidator,
UsuarioDao usuarioDao,
InstrutorEmAulaDao instrutorEmAulaDao) {
this._________ = _________;
}
[AE]fferent
coupling

47. public void generateRequestToken(CustomOAuthAccessor accessor) {
// generate oauth_token and oauth_secret
String consumer_key = accessor.getAccessor().consumer.getProperty("name");
// generate token and secret based on consumer_key
// for now use md5 of name + current time as token
String token_data = consumer_key + System.currentTimeMillis();
String token = scramble(token_data);
// creates secret accordingly
String secret_data = consumer_key + System.currentTimeMillis() + token;
String secret = scramble(secret_data);
accessor.setRequestToken(token);
accessor.setSecret(secret);
accessor.setAccessToken(null);
// add to the local cache
customAccessors.add(accessor);
}

48. public void generateRequestToken(CustomOAuthAccessor accessor) {
// generate oauth_token and oauth_secret
String consumer_key = accessor.getAccessor().consumer.getProperty("name");
// generate token and secret based on consumer_key
// for now use md5 of name + current time as token
String token_data = consumer_key + System.currentTimeMillis();
String token = scramble(token_data);
// creates secret accordingly
String secret_data = consumer_key + System.currentTimeMillis() + token;
String secret = scramble(secret_data);
accessor.setRequestToken(token);
accessor.setSecret(secret);
accessor.setAccessToken(null);
// add to the local cache
customAccessors.add(accessor);
}
Do not
comment

49. public void generateRequestToken(CustomOAuthAccessor accessor) {
// generate oauth_token and oauth_secret
String consumer_key = accessor.getAccessor().consumer.getProperty("name");
// generate token and secret based on consumer_key
// for now use md5 of name + current time as token
String token_data = consumer_key + System.currentTimeMillis();
String token = scramble(token_data);
// creates secret accordingly
String secret_data = consumer_key + System.currentTimeMillis() + token;
String secret = scramble(secret_data);
accessor.setRequestToken(token);
accessor.setSecret(secret);
accessor.setAccessToken(null);
// add to the local cache
customAccessors.add(accessor);
}
Do not
comment

50. ?

51. How
about...

52. Why is ugly a problem?

53. public class Pagamento {
public void paga (Funcionario f) {
int horasTrabalhadas = f.getHorasTrabalhadas();
if (f.getCargo() == Cargo.INSTRUTOR) {
horasTrabalhadas += f.getHorasAulaDadas();
}
double salario = f.getValorHora() * horasTrabalhadas;
imprimeRecibo(salario);
}
//...
}

54. public class Pagamento {
public void paga (Funcionario f) {
int horasTrabalhadas = f.getHorasTrabalhadas();
if (f.getCargo() == Cargo.INSTRUTOR) {
horasTrabalhadas += f.getHorasAulaDadas();
}
double salario = f.getValorHora() * horasTrabalhadas;
imprimeRecibo(salario);
}
//...
}

55. public class Pagamento {
public void paga (Funcionario f) {
int horasTrabalhadas = f.getHorasTrabalhadas();
if (f.getCargo() == Cargo.INSTRUTOR) {
horasTrabalhadas += f.getHorasAulaDadas();
}
double salario = f.getValorPorHora() * horasTrabalhadas;
if (f.getCargo() == Cargo.COMERCIAL) {
salario += f.getCursosVendidos() * f.valorComissao();
}
imprimeRecibo(salario);
}
}

58. Should
have
fixed me
earlier

59. Back to the start...

60. What are the
broken windows
in your team?

61. What are the
broken windows
in your team?
Are yours the same as
the person next to you?

62. What are the
broken windows
in your team?
How will
you fix
them?

69. Broken
windows de
práticas
Ceci Fernandes
@cecifernandes