Slides from Gregg Sporar's presentation on peer code review at the January 2010 meeting of Agile Austin. More information available here: http://blog.smartbear.com/the_smartbear_blog/2010/01/is-pair-programming-like-junior-high-sex.html.html

1. Peer Code Review: An Agile Process

2. Gregg Sporar Senior Product Manager [email_address] http://blog.smartbear.com http://twitter.com/smartbears

3. Code Collaborator codecollaborator.com

4. Code Collaborator codecollaborator.com

8. But is code review really Agile?

9. Individuals and interactions over processes and tools Working software over comprehensive documentation Customer collaboration over contract negotiation Responding to change over following a plan The Manifesto

10. Individuals and interactions over processes and tools Working software over comprehensive documentation Customer collaboration over contract negotiation Responding to change over following a plan The Manifesto

11. Working software is the primary measure of progress. Manifesto Principles - I

12. Working software is the primary measure of progress. Manifesto Principles - I

13. Getting to Working Software

17. Professional Writers Have Editors

19. Spell Czech: Good, butt knot enough

20. ROI: The Experiment

21. Rule of Bug: Earlier == Cheaper What if we had Peer Review? ? ? ?

22. $152k, down from $368k 32, down from 194

23. Move the Feedback

24. Agile processes promote sustainable development. The sponsors, developers, and users should be able to maintain a constant pace indefinitely. Manifesto Principles - II

25. Agile processes promote sustainable development. The sponsors, developers, and users should be able to maintain a constant pace indefinitely. Manifesto Principles - II

26. Agile processes promote sustainable development. The sponsors, developers, and users should be able to maintain a constant pace indefinitely . Manifesto Principles - II

27. Agile processes promote sustainable development. The sponsors, developers, and users should be able to maintain a constant pace indefinitely . Manifesto Principles - II

28. Bus Number >= 2

29. Collective Code Ownership

30. Continuous attention to technical excellence and good design enhances agility. Manifesto Principles - III

31. Continuous attention to technical excellence and good design enhances agility. Manifesto Principles - III

32. The Ego Effect

34. Continuous Learning

35. Are the meetings necessary?

36. Can We Avoid:

37. Formal Inspections Michael Fagan, IBM, 1976

38. Fagan Phases = Meeting

43. 4%

44. Fagan Phases = Meeting

45. Code review without meetings?

47. Adapt and Adjust

48. Over-the-Shoulder

49. Over-the-Shoulder Easy / Free Interruption No info Recorded Walk-through

50. Email

51. Email Easy / Free No Interruption / Remote Conversation Tracking Info. Hard to Retrieve No End?

52. Pair Programming

53. Pair Programming No Tools or Workflow Deep Thought Big Time Commitment No Info. Recorded Too Close

54. Tool-Assisted Review

55. Reviewers Identify Changes Package/Deliver Organize Communication Track Defects Audit Trail Reports Automatic Metrics Hapless Developer Version Control

56. Tool-Assisted Review Collection Communication Chronicling Install and Maintain Time or Money

57. Tools Code Collaborator Commercial Crucible Commercial Review Board Open-Source Rietveld/Gerrit Open-Source

58. What’s the most efficient use of time?

59. Cisco® MeetingPlace® Case Study 3,200,000 lines of code 2,500 reviews 50 developers 10 months San Diego, Bangalore, Budapest s

60. CodeReviewBook.com

61. 60-90 minutes max Time (minutes) Defects Found

62. Go slowly: 200-500 LOC/hour

63. Not too much: 200-400 LOC

64. Other Timely Topics

65. Checklist for Checklists 7  2 (George Miller, 1952) No obvious stuff Nothing that can be automated Stuff that’s easy to forget EXAMPLE: Errors handled properly in all cases

66. Version Control: Before or after check-in?

67. But won’t people hate doing code reviews?

68. Start Slowly

69. Selected Code Only Stable branch Core modules/10 scariest files Unit tests

70. No Flaming

71. It’s All About Tone Ask, Don’t Tell Don’t Accuse We All Make Mistakes

72. Careful Use of Metrics

73. We’re Agile - No Metrics!

74. Numbers, Numbers, Numbers LOC Time Defects Inspection and Defect Rates Defect Density

76. Review the Code Not the Coder

77. Properly Adjusted, Code Review is Agile

78. Gregg Sporar Senior Product Manager [email_address] http://blog.smartbear.com http://twitter.com/smartbears